Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast: add adjusted forecast #18867

Merged
merged 34 commits into from
Mar 6, 2025
Merged

Forecast: add adjusted forecast #18867

merged 34 commits into from
Mar 6, 2025

Conversation

andig
Copy link
Member

@andig andig commented Feb 16, 2025

This PR adds adjusted solar forecast. Depends on #19069.

As a next step this will support better algorithms, for example peak shaving (#18934). This PR adds the following features:

  • track daily PV generation (energyDemand.solarActual- generated until now)
  • calculate forecasted generation (energyDemand.solarForecasted- until now)
  • calculate an adjusted solar forecast based on actual generated vs. forecasted energy (forecast.solarAdjusted)

@naltatis ein erster Schritt damit auch aktiv etwas anzustellen. Würdest Du die im UI ergänzen wollen?

TODO

  • use timeseries instead of api.Rates for solar forecast @andig
  • use timeseries instead of api.Rates for ui @naltatis:
    Our forecast is really not a series of timespans but a series of discrete values per timestamp- changed type to avoid confusion. We can later decide if we need a different tariff type cause of this. Might also affect Co2 tariffs.
  • ui @naltatis
  • add fcst today remaining (and total), fcst tomorrow/ day after tomorrow, completeness per day @andig
  • keep today's forecast values when updating (Solar forecast: keep today's rates when merging #19069)
  • persist accumulated energy

Out of scope

  • persist forecast
  • use forecast for energy metrics
  • use forecast for planner

@andig andig added the enhancement New feature or request label Feb 16, 2025
@andig andig added the experimental Experimental feature label Feb 16, 2025
@andig andig changed the title Forecast: add energy demand metrics (experimental) Forecast: add adjusted forecast Feb 22, 2025
@andig andig added needs documentation Triggers issue creation in evcc-io/docs tariffs Specific tariff support labels Feb 22, 2025
@andig andig added the prio Priority label Feb 23, 2025
@andig andig force-pushed the feat/forecast-metrics branch from c5c8fab to 129cbe7 Compare February 24, 2025 12:22
@naltatis
Copy link
Member

adjust.webm

@naltatis
Copy link
Member

Das Scaling ist jetzt erst einmal nur für die Werte im Modal umgesetzt. Der "heute verbleibend" Wert muss auch noch mit dem Toggle angepasst werden.

@naltatis
Copy link
Member

@marq24

@andig andig merged commit 73b7014 into master Mar 6, 2025
5 of 6 checks passed
@andig andig deleted the feat/forecast-metrics branch March 6, 2025 13:53
@CiNcH83
Copy link
Contributor

CiNcH83 commented Mar 6, 2025

Interessantes Feature. Ich bin gerade dabei, open-meteo auszuprobieren. Da frage ich mich, was ich bei der efficiency eintragen soll. Interessant ist ja weniger, was an DC reinkommt, als mehr, was an AC rauskommt. Oder macht es Sinn, das evcc per solarAdjusted kompensieren zu lassen?

thecem pushed a commit to thecem/evcc that referenced this pull request Mar 6, 2025
@VolkerK62
Copy link
Contributor

Das hab ich bei Solcast zu efficiency gefunden
https://kb.solcast.com.au/what-is-the-efficiency-factor

@CiNcH83
Copy link
Contributor

CiNcH83 commented Mar 6, 2025

Ok, mit der efficiency soll man sich also empirisch der Realität annähern. Ist eigentlich genau das, was der PR hier automatisch macht!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experimental Experimental feature needs documentation Triggers issue creation in evcc-io/docs prio Priority tariffs Specific tariff support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants