Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final shader should not be applied on overlay #1500

Closed
Tracked by #1929
Meakk opened this issue Jun 29, 2024 · 4 comments
Closed
Tracked by #1929

Final shader should not be applied on overlay #1500

Meakk opened this issue Jun 29, 2024 · 4 comments
Assignees
Milestone

Comments

@Meakk
Copy link
Member

Meakk commented Jun 29, 2024

Describe the bug
Overlay widgets like filename or cheatsheet should be drawn after the final shader

@mwestphal mwestphal added this to F3D Jun 29, 2024
@Meakk Meakk moved this to To do in F3D Jul 1, 2024
@Meakk Meakk moved this from To do to Investigate in F3D Jul 1, 2024
@Meakk Meakk added this to the 3.0.0 milestone Jul 1, 2024
@mwestphal mwestphal modified the milestones: 3.0.0, 3.1.0 Jul 13, 2024
@samoncrief
Copy link
Contributor

I would like to work on this, though I'm still trying to dig up how the draw order and shaders are applied.

@mwestphal
Copy link
Contributor

Awesome, I just assigned it to you.

@Meakk
Copy link
Member Author

Meakk commented Jan 7, 2025

@samoncrief this one is challenging. Currently, there is a main pass taking care of everything (background, scene and overlay), then the userpass is postprocessing the result.
Basically, the overlay step in the main pass should be extracted to its own pass and be applied after the user pass.
Don't hesitate to ping me on Discord if you need to discuss

@mwestphal
Copy link
Contributor

Done in #1984

@github-project-automation github-project-automation bot moved this from Investigate to Done in F3D Feb 27, 2025
@mwestphal mwestphal mentioned this issue Feb 27, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants