Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USD fixes #1188

Closed
wants to merge 6 commits into from
Closed

USD fixes #1188

wants to merge 6 commits into from

Conversation

Meakk
Copy link
Member

@Meakk Meakk commented Jan 19, 2024 •
edited
Loading

Fix #1186 #1182 #1166
Improves #1185 #1184

@Meakk Meakk self-assigned this Jan 19, 2024
@Meakk Meakk changed the base branch from master to release January 19, 2024 15:53
@Meakk Meakk requested a review from mwestphal January 19, 2024 15:55
@Meakk Meakk mentioned this pull request Jan 19, 2024
Closed
@Meakk Meakk mentioned this pull request Jan 19, 2024
Closed
mwestphal
mwestphal approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming my remark is correct

@codecov Codecov
Copy link

codecov bot commented Jan 19, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b96663e) 96.42% compared to head (afaa03d) 96.41%.
Report is 1 commits behind head on release.

Files Patch % Lines
plugins/usd/module/vtkF3DUSDImporter.cxx 97.93% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           release    #1188      +/-   ##
===========================================
- Coverage    96.42%   96.41%   -0.01%     
===========================================
  Files          131      131              
  Lines         8000     8040      +40     
===========================================
+ Hits          7714     7752      +38     
- Misses         286      288       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal
Copy link
Contributor

no idea what is happening with CI

@Meakk Meakk mentioned this pull request Jan 19, 2024
Closed
@mwestphal mwestphal closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USD: Specific file is missing colors
2 participants
@Meakk @mwestphal