Center CheatSheet vertically

[Ni-g-3l]

Hello

I saw yesterday that I can help on some issues, so here is the first one.

This fix allow vertical alignment of CheatSheet

Feel free to comment and or ask me anything to change !

Linked Issue : #1780

Result :

[mwestphal]

Sorry I canceled your CI run, working on a CI issue right now

[mwestphal]

I restarted CI :)

[mwestphal]

So regarding the fix, I wonder if the cheatsheet overlay should stay closer to the text instead of extending all the way to the bottom/top ?

Wdyt ?

[Ni-g-3l]

I try to make the cheatsheet stay close to the text and I think it's much cleaner than the other one.

I you agree I can commit this change and fix CI too.

[mwestphal]

Looks great to me!

[Ni-g-3l]

I have a question ? Is there a command like : make format or something else, setup to project standard ?

[mwestphal]

make format or something else, setup to project standard ?

clang-format -i /path/to/file for a single file
(shopt -s globstar; clang-format -i **/*.{h,cxx} for the whole project

[mwestphal]

some errors to fix and baselines to update, you can download them from the CI pipeline.

[Ni-g-3l]

Done ! Thanks for the help !

[mwestphal]

none of the new baselines seems different, are you sure these changes are needed ?

[Ni-g-3l]

I think so ! Without updating Baselines CICD no longer pass

[mwestphal]

alright :)

[mwestphal]

small change needed.

[mwestphal]

@snoyer please review

[snoyer]

Look good, but did we lose the test where the window is actually taller than the cheatsheet @mwestphal?

[mwestphal]

Look good, but did we lose the test where the window is actually taller than the cheatsheet @mwestphal?

We did, as I want to avoid showing the raytracing stuff in the baselines to avoid duplicating baselines. Since the baseline were still impacted by the change, I guess its fine ?

[snoyer]

Look good, but did we lose the test where the window is actually taller than the cheatsheet @mwestphal?

We did, as I want to avoid showing the raytracing stuff in the baselines to avoid duplicating baselines. Since the baseline were still impacted by the change, I guess its fine ?

Coverage will be fine but the new feature/behavior isn't tested then? I don't know what would be the best solution here tho, add a test with a tall window but only test it on a single known config (eg. no raytracing)?

[mwestphal]

add a test with a tall window but only test it on a single known config (eg. no raytracing)?

Actually I'd rather add a test that only runs without raytracing.
Easier to update the baseline and the test is still valid and will be run in the mindeps CI.

@Ni-g-3l can you add a test with a long window that only run with raytracing is disabled ?

[mwestphal]

@snoyer please review

[mwestphal]

Thanks for your contribution @Ni-g-3l !