use system deps in github CI for fbthrift #595
Conversation
Save some time by not rebuilding cmake & boost et al on each CI run Summary: Regenerated github actions with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows fbthrift ``` Test Plan: CI
|
cc @vitaut looks like it speeds up GitHub CI |
| - name: Update system package info | ||
| run: sudo apt-get update | ||
| - name: Install system deps | ||
| run: sudo python3 build/fbcode_builder/getdeps.py --allow-system-packages install-system-deps --recursive fbthrift |
There was a problem hiding this comment.
This part worries me. I don't think we want to install system thrift when building thrift.
There was a problem hiding this comment.
This part worries me. I don't think we want to install system thrift when building thrift.
none of the getdeps manifest request a system dep for thrift, and not of their transient deps do either. Even it if was accidentally added somehow (e.g. someone manually installs ubuntu thrift-compiler), I think still good as the topo-sorted getdeps paths are added in front of the various _PATH env vars.
For further reassurance, not had an issue of folly system packages being found rather than the getdeps built ones
There was a problem hiding this comment.
Nevermind, I incorrectly assumed that this installs a system version of thrift itself in addition to dependencies.
|
So this bring the build time from ~38 to ~24 minutes? This is a nice improvement but I wonder if we can miss some build issues if we install dependencies instead of building with our own configs? |
@vitaut its already done for folly, I think its low risk to do fbthrift CI as well. The instructions from README usage suggest using the system deps, so CI will now test that more accurately |
|
I'm fine with this change but you need to import it into fbsource. |
|
@ahornby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: use system deps in github CI for fbthrift Save some time by not rebuilding cmake & boost et al on each CI run Regenerated github actions with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --free-up-disk --src-dir=. --output-dir=.github/workflows fbthrift ``` X-link: facebook/fbthrift#595 Reviewed By: vitaut, bigfootjon Differential Revision: D56162839 Pulled By: ahornby fbshipit-source-id: d0ed1ef779c839481e0903696e03e1e5624e08df
use system deps in github CI for fbthrift
Save some time by not rebuilding cmake & boost et al on each CI run
Summary:
Regenerated github actions with:
Test Plan:
CI