Code

Add support for abstract classes#4005

Code

Closed

popham wants to merge 22 commits intofacebook:masterfacebook/flow:masterfrom popham:abstract_class_methodspopham/flow:abstract_class_methodsCopy head branch name to clipboard

Commits

Commits on Jun 24, 2017

• Add abstract parsing for instance and class methods

  popham

  committed
  d74a3e3

  Copy full SHA for d74a3e3

• Plumb in the data structures for abstractness support

  popham

  committed
  12a3f3e

  Copy full SHA for 12a3f3e

• Set up the insttype.abstracts with GatherAbstractT

  popham

  committed
  fb25c24

  Copy full SHA for fb25c24

• Set up nonabstract assertion handling

  popham

  committed
  955e280

  Copy full SHA for 955e280

• Block abstract classes from ConstructorT and touching statics

  popham

  committed
  2e84b52

  Copy full SHA for 2e84b52

• Repair broken tests

  popham

  committed
  e7930b8

  Copy full SHA for e7930b8

• Vacuous toplevels for converted function types

  popham

  committed
  8338a92

  Copy full SHA for 8338a92

• Bug fix

  popham

  committed
  e049dd8

  Copy full SHA for e049dd8

• Label abstract methods as such in error messages

  popham

  committed
  8e00ca1

  Copy full SHA for 8e00ca1

• Remove misguided reservation

  popham

  committed
  cf7ad65

  Copy full SHA for cf7ad65

• Remove no-op reposition

  popham

  committed
  7b2e4ee

  Copy full SHA for 7b2e4ee

• Mixin facebookism rejects abstract classes cleanly

  popham

  committed
  db7b6b2

  Copy full SHA for db7b6b2

• Remove misguided reservation

  popham

  committed
  928cd61

  Copy full SHA for 928cd61

• Allow setting of static fields on abstract classes

  popham

  committed
  5679404

  Copy full SHA for 5679404

• Formalize personal TODOs for review

  popham

  committed
  0940c5c

  Copy full SHA for 0940c5c

• Punt on class property initializer safety

  popham

  committed
  028f8a2

  Copy full SHA for 028f8a2

• Under UnimplementedError, order list of abstracts by loc

  popham

  committed
  3cce5f8

  Copy full SHA for 3cce5f8

• OCD on whitespace

  popham

  committed
  d63d9c8

  Copy full SHA for d63d9c8

• Allow lookups without abstractness checking

  popham

  committed
  919c140

  Copy full SHA for 919c140

• Use AbstractClass<.> to move abstracts without abstractness checking

  popham

  committed
  af0f834

  Copy full SHA for af0f834

• Verify that this is still working properly

  popham

  committed
  bc065f1

  Copy full SHA for bc065f1

• Include new types

  popham

  committed
  1a95134

  Copy full SHA for 1a95134