Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename effect to effect_ as it is a reserver keyword in OCaml 5.3 #9268

Closed
wants to merge 1 commit into from

Conversation

filipeom
Copy link
Contributor

Fixes #9267

I don't know if any necessary adjustments need to be made to the documentation. We're changing the names of a few types and some labeled arguments, do the docs need to be updated anywhere?

Also, my editor runs ocamlformat when I save a file, so the diff might be larger because of that. Let me know if the formatting changes are unwanted, and I can remove them from the commit.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.)

@facebook-github-bot
Copy link
Contributor

@SamChou19815 merged this pull request in c3c2d08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for OCaml 5.3
2 participants