Rename effect
to effect_
as it is a reserver keyword in OCaml 5.3
#9268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9267
I don't know if any necessary adjustments need to be made to the documentation. We're changing the names of a few types and some labeled arguments, do the docs need to be updated anywhere?
Also, my editor runs
ocamlformat
when I save a file, so the diff might be larger because of that. Let me know if the formatting changes are unwanted, and I can remove them from the commit.