Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folly::detail::AccessSpreader<std::atomic>::getcpuFunc Not Found #516

Closed
helloleef opened this issue Nov 16, 2016 · 7 comments
Closed

folly::detail::AccessSpreader<std::atomic>::getcpuFunc Not Found #516

helloleef opened this issue Nov 16, 2016 · 7 comments

Comments

@helloleef
Copy link

helloleef commented Nov 16, 2016

link libfolly.a , g++6.2 , Error info is

folly/detail/CacheLocality.h:256: undefined reference to folly::detail::AccessSpreader<std::atomic>::getcpuFunc

@jack17529
Copy link

jack17529 commented Jul 1, 2017

@Orvid Can I work on this one?

@Orvid
Copy link
Contributor

Orvid commented Jul 3, 2017

That function no longer lives in detail/CacheLocality.h, it's been moved to concurrency/CacheLocality.h. If you can still reproduce the issue then feel free to fix it.

@jack17529
Copy link

@Orvid , this may be a silly question , but may I please know what does this line do -
https://github.com/facebook/folly/blob/master/folly/concurrency/CacheLocality.h#L96
I only have coded introductory templates.

@Orvid
Copy link
Contributor

Orvid commented Jul 13, 2017

It declares Atom as a template template parameter:
http://en.cppreference.com/w/cpp/language/template_parameters#Template_template_parameter

@jack17529
Copy link

@Orvid can you please explain the meaning behind doing - https://github.com/facebook/folly/blob/master/folly/concurrency/CacheLocality.h#L385
this ?

@Orvid
Copy link
Contributor

Orvid commented Jul 17, 2017

It's popping a value off of the free-list that had been previously pushed to at:
https://github.com/facebook/folly/blob/master/folly/concurrency/CacheLocality.h#L407
by storing the previous value in the first 8-bytes of the allocation.

@jack17529
Copy link

@Orvid the vcpkg installed old repositories in my system and is now not updating them , I have opened issue on vcpkg repository for this .

facebook-github-bot pushed a commit that referenced this issue Aug 22, 2022
Summary:
X-link: facebook/fbthrift#516

X-link: facebook/watchman#1050

X-link: facebook/proxygen#426

Pull Request resolved: #1842

X-link: facebook/fboss#117

Sadly, even though Ubuntu 18.04 is still in LTS, GitHub is deprecating
its runner image.

Migrate the generated GitHub Actions to 20.04.

actions/runner-images#6002

https://github.blog/changelog/2022-08-09-github-actions-the-ubuntu-18-04-actions-runner-image-is-being-deprecated-and-will-be-removed-by-12-1-22/

Reviewed By: fanzeyi

Differential Revision: D38877286

fbshipit-source-id: 85f3324d6666eacb190a43985585b438de69d545
@yfeldblum yfeldblum closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants