Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why is INTERSECT_INJECTION called in a define? #529

Closed
eantoranz opened this issue Jul 18, 2012 · 1 comment
Closed

why is INTERSECT_INJECTION called in a define? #529

eantoranz opened this issue Jul 18, 2012 · 1 comment

Comments

@eantoranz
Copy link

Hi!

I have this rather large codebase I'm trying to "mount" on hiphop. I'm having problems when making calls to php's define(). Is it because parameters are not literal values but variables and calculated values?
@eantoranz
Copy link
Author

From what I see in the cpp code generated from our php, INTERCEPT_INJECTION is not the replacement of define() so this thread is dead on its tracks

facebook-github-bot pushed a commit that referenced this issue Sep 28, 2022
@sashashura @facebook-github-bot
GitHub Workflows security hardening (#529)
5a0a7ae 
Summary:
This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best practice because by default workflows run with [extended set of permissions](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) (except from `on: pull_request` [from external forks](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an [injection](https://securitylab.github.com/research/github-actions-untrusted-input/) or compromised third party tool or action) is restricted.
It is recommended to have [most strict permissions on the top level](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions) and grant write permissions on [job level](https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs) case by case.

X-link: facebook/fbthrift#529

Reviewed By: ParalaxRus

Differential Revision: D39866397

Pulled By: ParalaxRus

fbshipit-source-id: 3c921df4845618c2091be45e3702d4e639c7da46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eantoranz