Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimerMixin] Remove TimerMixin from TouchableOpacity #21520

Closed
wants to merge 1 commit into from

Conversation

danibonilha
Copy link
Contributor

@danibonilha danibonilha commented Oct 5, 2018

Related to #21485
This PR removes TimerMixin from TouchableOpacity

Test Plan:

All flow types passes
Ran RNTester

out

Release Notes:

[GENERAL] [ENHANCEMENT] [TouchableOpacity.js] - Removed TimerMixin.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 5, 2018
@danibonilha danibonilha changed the title Remove TimerMixin from TouchableOpacity [TimerMixin] Remove TimerMixin from TouchableOpacity Oct 5, 2018
@pull-bot
Copy link

pull-bot commented Oct 5, 2018

Warnings
⚠️

📋 Release Notes - This PR may have incorrectly formatted Release Notes.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Oct 5, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@react-native-bot
Copy link
Collaborator

@danibonilha merged commit 9282c9d into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 6, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 6, 2018
@danibonilha danibonilha deleted the timer-mixin branch October 11, 2018 02:31
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
Related to facebook#21485
This PR removes TimerMixin from TouchableOpacity
Pull Request resolved: facebook#21520

Differential Revision: D10223753

Pulled By: RSNara

fbshipit-source-id: fc02077de7e73ee968b7944c0178892825099063
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants