Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flow-strict] Flow strict StaticContainer #22121

Closed
wants to merge 13 commits into from
Closed

[flow-strict] Flow strict StaticContainer #22121

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
38d2109
TVViewPropTypes, PlatformViewPropTypes, DeprecatedTVViewPropTypes
exced Sep 27, 2018
415fa86
UPDATE: @format
exced Sep 27, 2018
396b19d
UPDATE: DeprecatedTVViewPropTypes clean + rm comments
exced Sep 27, 2018
c62a88f
UPDATE: TVViewPropTypes header
exced Sep 27, 2018
4955d23
UPDATE: Headers
exced Sep 27, 2018
f81976a
UPDATE: TVViewPropTypes tvParallaxProperties
exced Sep 27, 2018
ae91f74
UPDATE: TVViewPropTypes $ReadOnly
exced Sep 27, 2018
12d9209
UPDATE: remove TimerMixin
exced Oct 4, 2018
b38cc0d
MERGE: ListView
exced Oct 22, 2018
9e85e75
Merge remote-tracking branch 'upstream/master'
exced Oct 29, 2018
e777a12
Merge remote-tracking branch 'upstream/master'
exced Nov 4, 2018
b541e7c
Merge remote-tracking branch 'upstream/master'
exced Nov 4, 2018
b906b30
UPDATE: Flow strict mode
exced Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions Libraries/Components/StaticContainer.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*
* @format
* @flow
* @flow strict-local
*/

'use strict';
Expand All @@ -27,8 +27,19 @@ const React = require('React');
* Typically, you will not need to use this component and should opt for normal
* React reconciliation.
*/
class StaticContainer extends React.Component<Object> {
shouldComponentUpdate(nextProps: Object): boolean {

type Props = $ReadOnly<{|
/**
* Whether or not this component should update.
*/
shouldUpdate: ?boolean,
/**
* Content short-circuited by React reconciliation process.
*/
children: React.Node,
|}>;
class StaticContainer extends React.Component<Props> {
shouldComponentUpdate(nextProps: Props): boolean {
return !!nextProps.shouldUpdate;
}

Expand Down