Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flow-strict] Flow strict-local in TimePickerAndroid.ios.js #22155

Closed
wants to merge 1 commit into from
Closed

[flow-strict] Flow strict-local in TimePickerAndroid.ios.js #22155

wants to merge 1 commit into from

Conversation

binaryta
Copy link
Contributor

@binaryta binaryta commented Nov 5, 2018

Related to #22100

Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.ios.js.

Test Plan:

  • npm run prettier
  • npm run flow
  • npm run flow-check-ios
  • npm run flow-check-android
  • npm run lint
  • npm run test

Changelog:

[GENERAL][ENHANCEMENT][TimePickerAndroid.android.ios.js] - apply flow strict-local

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2018
@pull-bot
Copy link

pull-bot commented Nov 5, 2018

Warnings
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@RSNara RSNara changed the title Flow strict-local in TimePickerAndroid.android.ios.js [flow-strict] Flow strict-local in TimePickerAndroid.android.ios.js Nov 5, 2018
RSNara
RSNara requested changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

This looks good but I think we should merge this PR with #22154 to avoid duplicating the Options type. What do you think?

@RSNara RSNara changed the title [flow-strict] Flow strict-local in TimePickerAndroid.android.ios.js [flow-strict] Flow strict-local in TimePickerAndroid.ios.js Nov 6, 2018
@RSNara
Copy link
Contributor

RSNara commented Nov 12, 2018

Update: I'll let you know after #22188 lands, so that we can update this PR accordingly.

@binaryta
Copy link
Contributor Author

@RSNara Thanks.

@binaryta binaryta closed this Dec 19, 2018
@binaryta binaryta deleted the flow-strict-time-picker-android-ios branch December 19, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSNara RSNara RSNara requested changes

Assignees
No one assigned
Labels
API: TimePickerAndroid CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Flow Platform: Android Android applications. Platform: iOS iOS applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@binaryta @pull-bot @RSNara @hramos @facebook-github-bot @react-native-bot