[flow-strict] Flow strict-local in TimePickerAndroid.android.ios.js #22714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
yushimatenjin
changed the title
react-native-bot
added
Flow
🔶APIs
API: TimePickerAndroid
Platform: Android
TimePickerAndroid.ios.js
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
approved these changes
Jan 25, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@yushimatenjin merged commit 2ed1bb2 into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Related to facebook#22100 Enhance TimePickerAndroid flow types. Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.ios.js. All flow tests succeed. [General] [Changed] - Enhance Flow types definitions Pull Request resolved: facebook#22714 Differential Revision: D13817142 Pulled By: cpojer fbshipit-source-id: 9d0f0b0629966a60d77b73ba8a6bba4e1a4e2337
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #22100
Enhance TimePickerAndroid flow types.
Turn Flow strict mode on for Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.ios.js.
Test Plan:
All flow tests succeed.
Changelog:
[General] [Changed] - Enhance Flow types definitions