Fix elevation with border-radius set #48982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68724947 |
jorge-cab
added a commit
to jorge-cab/react-native
that referenced
this pull request
Jan 27, 2025
Summary: We were missing a conversion to px on the `getOutline()` function of `CompositeBackgroundDrawable` which led to incorrect elevation prop rendering Reviewed By: NickGerleman Differential Revision: D68724947
jorge-cab
force-pushed
the
export-D68724947
branch
from
910c9a4 to
6cb8fd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68724947 |
Summary: We were missing a conversion to px on the `getOutline()` function of `CompositeBackgroundDrawable` which led to incorrect elevation prop rendering Reviewed By: NickGerleman Differential Revision: D68724947
jorge-cab
force-pushed
the
export-D68724947
branch
from
6cb8fd1 to
09de1ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68724947 |
|
This pull request has been merged in f7d78f8. |
robhogan
pushed a commit
that referenced
this pull request
Feb 11, 2025
Summary: Pull Request resolved: #48982 We were missing a conversion to px on the `getOutline()` function of `CompositeBackgroundDrawable` which led to incorrect elevation prop rendering Changelog: [Android][Fixed] - Elevation prop on android has incorrect border-radius Reviewed By: NickGerleman Differential Revision: D68724947 fbshipit-source-id: b3a7a4919bfd7c60fac7c3d6e3ba760e3f74d190
polovi
added a commit
to polovi/react-native
that referenced
this pull request
Mar 6, 2025
cortinico
added a commit
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We were missing a conversion to px on the
getOutline()function ofCompositeBackgroundDrawablewhich led to incorrect elevation prop renderingReviewed By: NickGerleman
Differential Revision: D68724947
#48874