Use Prettier Config API #11980
Use Prettier Config API #11980
Conversation
| @@ -7,98 +7,67 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Based on similar script in Jest | |||
| // https://github.com/facebook/jest/blob/master/scripts/prettier.js | |||
| // https://github.com/facebook/jest/blob/a7acc5ae519613647ff2c253dd21933d6f94b47f/scripts/prettier.js | |||
There was a problem hiding this comment.
This file has since been removed from Jest.
| console.log(file); | ||
| files.forEach(file => { | ||
| const options = prettier.resolveConfig.sync(file, { | ||
| config: prettierConfigPath, |
There was a problem hiding this comment.
Passing in the path explicitly avoids looking up the FS tree for each file.
| return; | ||
| } | ||
| if (!files.length) { | ||
| return; |
There was a problem hiding this comment.
Are we ok with top-level return? I could change it to process.exit().
|
Most of the time i use eslint for checking purpose, i think this is does`t matter :) |
|
@blling This repository doesn't use eslint-plugin-prettier. |
|
@azz I am sorry, i mean in |
|
@blling I'm not sure how ESLint is relevant to the PR. This PR just fixes the default behaviour of Prettier editor integrations, which many people use to format code on save. |
|
@azz En, Some of the ESLint rule is the same as Prettier rule, eg: |
No, Prettier is a fundamentally different tool to ESLint. ESLint is used to enforce particular sets of rules based on static analysis. It just so happens that some of those rules have localized fixes. Prettier on the other hand formats the entire file from scratch, and has some options to change the output slightly. Using Prettier when you save a file means that you don't have to worry about formatting your code manually at all almost. ESLint doesn't offer that. There's some more info in the Prettier docs: https://prettier.io/docs/en/comparison |
|
This is awesome, thank you! |
|
Update HTTP to HTTPs in CHANGELOG.md ( |
|
Thanks you account disabled soon as my facebook |
Currently when a developer is using a text editor Prettier plugin such as prettier-vscode or prettier-atom, the formatting functionality will format the files with incorrect settings (such as double quotes and no trailing commas). This is easily fixed by moving a lot of the logic in
scripts/prettier/index.jsupstream to Prettier via a configuration (.prettierrc.js) file.I've used
scripts/shared/pathsByLanguageVersionto maintain the addition of thetrailingComma: "all"setting for ESNext files.All four "modes" (
check,check-changed,write,write-changed) have been maintained.I have tested this by enabling format-on-save in prettier-vscode and saving both ES5 and ESNext files to check if the correct settings are applied. I have also tested the
check-changedandwrite-changedfiles apply the correct rules to the two different types of files.