Code

create-subscription#12325

Code

Merged

bvaughn merged 54 commits intofacebook:masterfacebook/react:masterfrom bvaughn:create-component-with-subscriptionsbvaughn/react:create-component-with-subscriptionsCopy head branch name to clipboardMar 13, 2018

Commits

Commits on Mar 5, 2018

• POC for create-component-with-subscriptions

  bvaughn

  committed
  d5d8bf6

  Copy full SHA for d5d8bf6

• Updated README

  bvaughn

  committed
  7b1e8c2

  Copy full SHA for 7b1e8c2

• Added Rollup bundle

  bvaughn

  committed
  f8743b3

  Copy full SHA for f8743b3

• Expanded tests

  bvaughn

  committed
  4304b55

  Copy full SHA for 4304b55

• Updated bundle comment

  bvaughn

  committed
  30eb16a

  Copy full SHA for 30eb16a

• Added a test for "cold" observable

  bvaughn

  committed
  eb1372c

  Copy full SHA for eb1372c

• Updated inline comments

  bvaughn

  committed
  88e7e22

  Copy full SHA for 88e7e22

• Updated README examples

  bvaughn

  committed
  c395051

  Copy full SHA for c395051

• Added a test (and README docs) for Promises

  bvaughn

  committed
  78c9a4c

  Copy full SHA for 78c9a4c

• Added a caveat about Promises to README

  bvaughn

  committed
  d1fc6e8

  Copy full SHA for d1fc6e8

Commits on Mar 6, 2018

• Use a HOC for functional components and a mixin for ES6 components

  bvaughn

  committed
  2e98ca9

  Copy full SHA for 2e98ca9

• Added tests for create-react-class

  bvaughn

  committed
  5093ab4

  Copy full SHA for 5093ab4

• Flow fix

  bvaughn

  committed
  54468e8

  Copy full SHA for 54468e8

• Added a ref test

  bvaughn

  committed
  6b16b7c

  Copy full SHA for 6b16b7c

• Added a test for react-lifecycles-compat

  bvaughn

  committed
  d05ffa3

  Copy full SHA for d05ffa3

• Updated README to show class component

  bvaughn

  committed
  bd36fb4

  Copy full SHA for bd36fb4

• Added docs for default values

  bvaughn

  committed
  a11164e

  Copy full SHA for a11164e

• Improved README examples

  bvaughn

  committed
  31edf59

  Copy full SHA for 31edf59

• Simplified Promise docs and added additional test

  bvaughn

  committed
  256c5e5

  Copy full SHA for 256c5e5

• Swapped functional/class component usage in examples

  bvaughn

  committed
  6dcac15

  Copy full SHA for 6dcac15

• Split internal and public API tests

  bvaughn

  committed
  39d7ba8

  Copy full SHA for 39d7ba8

• Tweaks

  bvaughn

  committed
  b5571c1

  Copy full SHA for b5571c1

• Changed impl to only support one subscription per component

  bvaughn

  committed
  2192fd5

  Copy full SHA for 2192fd5

• Docs tweak

  bvaughn

  committed
  fdfa22b

  Copy full SHA for fdfa22b

• Docs tweaks

  bvaughn

  committed
  afeb6cd

  Copy full SHA for afeb6cd

Commits on Mar 7, 2018

• Refactored create-subscription to more closely mimic context API

  bvaughn

  committed
  7532184

  Copy full SHA for 7532184

• Renamed create-component-with-subscriptions => create-subscription

  bvaughn

  committed
  0f936ba

  Copy full SHA for 0f936ba

• Renamed references to create-subscription

  bvaughn

  committed
  2d824c2

  Copy full SHA for 2d824c2

• Replaced .toThrow with .toWarnDev

  bvaughn

  committed
  3edff49

  Copy full SHA for 3edff49

• Disable render-phase side effects

  bvaughn

  committed
  e056172

  Copy full SHA for e056172

• Updated docs

  bvaughn

  committed
  9bdc6d6

  Copy full SHA for 9bdc6d6

• README and naming tweaks

  bvaughn

  committed
  9ffe079

  Copy full SHA for 9ffe079

• README tweaks

  bvaughn

  committed
  629f145

  Copy full SHA for 629f145

• Wording tweak

  bvaughn

  committed
  48b4a1b

  Copy full SHA for 48b4a1b

• Inline comments tweak

  bvaughn

  committed
  ee2ae93

  Copy full SHA for ee2ae93

• Minor test tidying up

  bvaughn

  committed
  64d80b8

  Copy full SHA for 64d80b8

• Added more context to README intro

  bvaughn

  committed
  ad190fb

  Copy full SHA for ad190fb

• Wordsmith nit picking

  bvaughn

  committed
  3288726

  Copy full SHA for 3288726

• Wordsmith nit picking

  bvaughn

  committed
  81f2695

  Copy full SHA for 81f2695

• Replaced Value with Value | void type

  bvaughn

  committed
  267a76b

  Copy full SHA for 267a76b

• Tweaks in response to Flarnie's feedback

  bvaughn

  committed
  db7b84f

  Copy full SHA for db7b84f

• Added RxJS for tests instead of fake impls

  bvaughn

  committed
  32d6d40

  Copy full SHA for 32d6d40

• Improved children Flow type slightly

  bvaughn

  committed
  5557120

  Copy full SHA for 5557120

• Added Flow <> around config

  bvaughn

  committed
  ee3dfcc

  Copy full SHA for ee3dfcc

Commits on Mar 8, 2018

• Fixed example imports in README

  bvaughn

  authored
  a2f43a5

  Copy full SHA for a2f43a5

• Replaced createComponent() references with createSubscription() in README

  bvaughn

  authored
  4e57ed7

  Copy full SHA for 4e57ed7

• Changed subscribe() to return an unsubscribe method (or false)

  bvaughn

  committed
  f0c68b8

  Copy full SHA for f0c68b8

Commits on Mar 12, 2018

• Flow type tweak

  bvaughn

  committed
  63a65e6

  Copy full SHA for 63a65e6

Commits on Mar 13, 2018

• Merge branch 'master' into create-component-with-subscriptions

  bvaughn

  committed
  e6740aa

  Copy full SHA for e6740aa

• Responded to Andrew's PR feedback

  bvaughn

  committed
  c116528

  Copy full SHA for c116528

• Docs updatE

  bvaughn

  committed
  c1dd9a7

  Copy full SHA for c1dd9a7

• Flow tweak

  bvaughn

  committed
  e10e2fc

  Copy full SHA for e10e2fc

• Addressed PR feedback from Flarnie

  bvaughn

  committed
  f03dfa9

  Copy full SHA for f03dfa9

• Removed contradictory references to Flux stores in README

  bvaughn

  committed
  6f740d9

  Copy full SHA for 6f740d9