-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable createEventHandle API for wWW test builds #19262
Merged
bvaughn
merged 1 commit into
facebook:master
from
bvaughn:enable-create-event-api-in-testing-build
Jul 6, 2020
Merged
Enable createEventHandle API for wWW test builds #19262
bvaughn
merged 1 commit into
facebook:master
from
bvaughn:enable-create-event-api-in-testing-build
Jul 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickhanlonii
approved these changes
Jul 6, 2020
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2d19a5b:
|
Details of bundled changes.Comparing: 1cbaf48...2d19a5b react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Details of bundled changes.Comparing: 1cbaf48...2d19a5b react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
trueadm
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Scott is unable to test the new test selector API because code that uses
useEvent
will cause null runtime errors (sincecreateEventHandle
returnsnull
unless this flag is enabled).