Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Optimize Images yarn command (part 2) #21968

Merged
merged 14 commits into from
Aug 2, 2021
Prev Previous commit
Next Next commit
fix error handling
ilhamsyahids committed Jul 27, 2021
commit 9594f543c5cf31ba3657734ca04df0239c76fac0
25 changes: 12 additions & 13 deletions scripts/images/improvedImages.mjs
Original file line number Diff line number Diff line change
@@ -64,22 +64,21 @@ const optimized = async (filename) => {

try {
await imagemin([filename], pluginsOptions)
} catch (err) {
console.info(chalk.red(`Skip ${filename} due to error when optimizing`));

return;
}
const fileSizeAfter = size(filename)
const fileSizeDiff = fileSizeBefore - fileSizeAfter
if (fileSizeDiff > 0){
savedSize += fileSizeDiff
console.info(chalk.green(`Optimized ${filename}: ${chalk.yellow(readableSize(fileSizeAfter))}`))
} else { // file after same or bigger
// restore previous file
fs.renameSync(filenameBackup, filename)

const fileSizeAfter = size(filename)
const fileSizeDiff = fileSizeBefore - fileSizeAfter
if (fileSizeDiff > 0){
savedSize += fileSizeDiff
console.info(chalk.green(`Optimized ${filename}: ${chalk.yellow(readableSize(fileSizeAfter))}`))
} else { // file after same or bigger
// restore previous file
fs.renameSync(filenameBackup, filename)
console.info(`${filename} ${chalk.red(`already optimized`)}`)
}

console.info(`${filename} ${chalk.red(`already optimized`)}`)
} catch (err) {
console.info(chalk.red(`Skip ${filename} due to error when optimizing`));
}

// delete backup file