abort if no args provided to sl pr pull #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discentem
changed the title
|
@bolinfest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@discentem did you mean to close this? |
|
@bolinfest 🤔 I closed because I thought if it's imported, that's equivalent to merging for this project? If that's not the case, let's reopen? 😅 |
|
@discentem sorry for the confusion: that means it has been imported in our internal repo where it has to be reviewed (and unfortunately is the only place where we can run tests against it right now) and then approved, and is ultimately exported back to GitHub, at which point this PR will automatically be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abort if no args provided to sl pr pull
Stack created with Sapling. Best reviewed with ReviewStack.