Add boxed module #250
Merged
Add boxed module #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2021 prelude includes TryFrom and TryInto [1]. And recently the nigtlhy channel started linting for this duplicated imports and emitting warnings. This removes the redundant imports. 1: https://doc.rust-lang.org/core/prelude/rust_2021/index.html
This allows downstream packages to write `use boxed::*`, and circumvent the issue with redundant imports.
hackaugusto
force-pushed
the
hacka-export-boxed
branch
from
ddb7f0d to
f0cb1b8
Compare
irakliyk
approved these changes
Feb 21, 2024
This was referenced Feb 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #249
This moves the re-export of
Boxinto a module namedboxed. So that downstream crates writeuse utils::boxed::*and circumvent the issue with #249