Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for algebraic/curve batching for constraint composition polynomial #363

Merged
merged 4 commits into from
Feb 9, 2025
Merged

Add option for algebraic/curve batching for constraint composition polynomial #363

merged 4 commits into from
Feb 9, 2025

Conversation

Al-Kindi-0
Copy link
Contributor

Closes #362

irakliyk
irakliyk reviewed Feb 6, 2025
View reviewed changes
irakliyk
irakliyk reviewed Feb 6, 2025
View reviewed changes
@Al-Kindi-0 Al-Kindi-0 mentioned this pull request Feb 6, 2025
Open
@Al-Kindi-0 Al-Kindi-0 force-pushed the al-add-option-algebraic-batching-constraint-poly branch from 368285b to 3303260 Compare February 7, 2025 08:15
@Al-Kindi-0
Copy link
Contributor Author

Added a round trip test for the serialization of ProofOptions

irakliyk
irakliyk approved these changes Feb 9, 2025
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@irakliyk irakliyk merged commit 2f0cbfd into facebook:main Feb 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use algebraic/curve batching for constraints
3 participants
@Al-Kindi-0 @irakliyk @facebook-github-bot