Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional compilation when targeting fuzzers #3768

Closed
wants to merge 1 commit into from

Conversation

GregTho
Copy link

@GregTho GregTho commented Sep 21, 2023

ZSTD_assertValidSequence is only called when both
FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION and
FUZZING_ASSERT_VALID_SEQUENCE are defined. Match those conditions for the function's definition. Additionally, ZSTD_assertValidSequence only calls ZSTD_dictionaryIsActive when DEBUGLEVEL >= 1, so only define it under that condition.

…ionaryIsActive

ZSTD_assertValidSequence is only called when both
FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION and
FUZZING_ASSERT_VALID_SEQUENCE are defined. Match those conditions for
the function's definition. Additionally, ZSTD_assertValidSequence only
calls ZSTD_dictionaryIsActive when DEBUGLEVEL >= 1, so only define it
under that condition.
@facebook-github-bot
Copy link

Hi @GregTho!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@terrelln
Copy link
Contributor

Superseded by #3770.

@terrelln terrelln closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants