Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Enable the strip-optnone-attribute binary to take a list of paths #554

Merged

Conversation

ChrisCummins
Copy link
Contributor

This extends the strip-optnone-attribute binary to take a list of zero
or more bitcodes to modify, rather than requiring a single argument.

…ths.

This extends the strip-optnone-attribute binary to take a list of zero
or more bitcodes to modify, rather than requiring a single argument.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #554 (97cb9cb) into development (51e3c0a) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #554      +/-   ##
===============================================
- Coverage        87.88%   87.81%   -0.07%     
===============================================
  Files              113      113              
  Lines             6486     6486              
===============================================
- Hits              5700     5696       -4     
- Misses             786      790       +4     
Impacted Files Coverage Δ
...loop_tool/service/loop_tool_compilation_session.py 88.59% <0.00%> (-0.68%) ⬇️
compiler_gym/envs/compiler_env.py 91.60% <0.00%> (-0.50%) ⬇️
compiler_gym/service/connection.py 76.97% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e3c0a...97cb9cb. Read the comment docs.

Copy link
Contributor

@hughleat hughleat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just curious though. Is this somehow related to -Xclang -disable-O0-optnone?

@ChrisCummins
Copy link
Contributor Author

Just curious though. Is this somehow related to -Xclang -disable-O0-optnone?

Yes. This binary is used to rewrite LLVM bitcodes that have already been prepared. E.g. there's a big dataset of bitcodes that were all compiled with -O0, this binary enables them to be used as gym envs.

Cheers,
Chris

@ChrisCummins ChrisCummins merged commit 22ac844 into facebookresearch:development Feb 7, 2022
@ChrisCummins ChrisCummins deleted the feature/strip-opts branch February 7, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants