-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Handful of small tweaks #567
[cmake] Handful of small tweaks #567
Conversation
The polly project is not used by CompilerGym.
Fixes the (harmless) typo "string" in place of "STRING", causing the following warning: -- Install configuration: "Release" CMake Warning (dev) at build_tools/cmake/FindCsmith.cmake:52 (set): implicitly converting 'string' to 'STRING' type. Call Stack (most recent call first): external/external.cmake:397 (find_package) CMakeLists.txt:64 (include) This warning is for project developers. Use -Wno-dev to suppress it.
cc @sogartar (I can't add you as a reviewer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any remarks. Since you mention that parse_initialize_pass
is a "throw-away" code, I was not thorough with its review.
This makes the (dodgy AF) C++ parsing logic slightly more robust by fixing a couple of bugs where concatenated string were not correctly interpreted, and where comments were not parsed properly.
ef1fe8d
to
a656289
Compare
Codecov Report
@@ Coverage Diff @@
## development #567 +/- ##
============================================
Coverage 88.06% 88.06%
============================================
Files 114 114
Lines 6693 6693
============================================
Hits 5894 5894
Misses 799 799 Continue to review full report at Codecov.
|
This patch set:
s/string/STRING/
that caused a harmless error to be printed.include/
prefix from all LLVM header includes, and the workaround in the CMake config.