Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC header include path. #605

Merged

Conversation

ChrisCummins
Copy link
Contributor

Strip the include/ directory prefix.

@ChrisCummins ChrisCummins requested a review from hughleat March 4, 2022 15:49
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2022
@ChrisCummins ChrisCummins force-pushed the fix/grpc-header-path branch from 9a8d4f7 to 980aa3a Compare March 4, 2022 15:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #605 (980aa3a) into development (d5d60b6) will decrease coverage by 6.46%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #605      +/-   ##
===============================================
- Coverage        88.26%   81.79%   -6.47%     
===============================================
  Files              114      114              
  Lines             6708     6708              
===============================================
- Hits              5921     5487     -434     
- Misses             787     1221     +434     
Impacted Files Coverage Δ
...er_gym/third_party/inst2vec/inst2vec_preprocess.py 10.72% <0.00%> (-63.22%) ⬇️
compiler_gym/envs/llvm/compute_observation.py 31.81% <0.00%> (-59.10%) ⬇️
compiler_gym/envs/llvm/datasets/clgen.py 43.28% <0.00%> (-46.27%) ⬇️
compiler_gym/envs/llvm/llvm_benchmark.py 51.09% <0.00%> (-42.34%) ⬇️
compiler_gym/third_party/inst2vec/__init__.py 56.66% <0.00%> (-36.67%) ⬇️
compiler_gym/envs/llvm/datasets/llvm_stress.py 58.33% <0.00%> (-33.34%) ⬇️
compiler_gym/envs/llvm/datasets/chstone.py 51.21% <0.00%> (-31.71%) ⬇️
compiler_gym/envs/llvm/datasets/csmith.py 55.26% <0.00%> (-31.58%) ⬇️
compiler_gym/util/commands.py 54.76% <0.00%> (-30.96%) ⬇️
compiler_gym/validation_result.py 70.00% <0.00%> (-12.86%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d60b6...980aa3a. Read the comment docs.

Copy link
Contributor

@hughleat hughleat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisCummins ChrisCummins merged commit 8cf7edd into facebookresearch:development Mar 6, 2022
@ChrisCummins ChrisCummins deleted the fix/grpc-header-path branch March 6, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants