-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build system tweaks patchset #618
Build system tweaks patchset #618
Conversation
d56653d
to
43e6dfc
Compare
Codecov Report
@@ Coverage Diff @@
## development #618 +/- ##
===============================================
- Coverage 88.60% 88.54% -0.06%
===============================================
Files 115 115
Lines 7019 7019
===============================================
- Hits 6219 6215 -4
- Misses 800 804 +4
Continue to review full report at Codecov.
|
8517236
to
5df669f
Compare
ProGraML v0.3.2 fixes a bug in which the outgoing edge position was 0 for all outgoing edges of a block, regardless of how many unique edges there are.
As best as I can tell this is only useful for debugging.
It is clearer to read as there is a mixture of build_tools and third party packages..
This newer version incorporates a fix for a build error on Ubuntu 21.04.
Fix build error.
5df669f
to
252e09f
Compare
This was removed in facebookresearch#600.
Merging PR facebookresearch#600 set the cmake build on fire.
a090fd6
to
9f99191
Compare
9f99191
to
f079693
Compare
@sogartar could you take a quick look at this? Cheers, |
The docker setup action is flaky, and the issue tracker shows that this is a common problem: https://github.com/docker-practice/actions-setup-docker/issues
Merging now as this fixes the Cheers, |
This pull request makes two important changes to the build:
And a bunch of smaller tweaks to the CMake build:
My eventual goal is to add support for CMake on macOS (#618), but I am hitting a problem with the protobuf configuration step (
autoreconf
) inexternal/protobuf/build_protobuf.cmake
:For some reason, the configure script doesn't like the detected C/C++ compiler. I'll pick this up at a later date.