Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code distance C++ unit tests for ROCm on MI250 #3787

Closed
2 of 4 tasks
ramilbakhshyiev opened this issue Aug 23, 2024 · 2 comments
Closed
2 of 4 tasks

Fix code distance C++ unit tests for ROCm on MI250 #3787

ramilbakhshyiev opened this issue Aug 23, 2024 · 2 comments
Assignees
@ramilbakhshyiev
Labels
bug GPU module: rocm

Comments

@ramilbakhshyiev
Copy link
Contributor

Summary

TestGpuIndexIVFPQ.Query_L2_MMCodeDistance
TestGpuIndexIVFPQ.Query_IP_MMCodeDistance

Platform

ROCm

Running on:

  • CPU
  • GPU

Interface:

  • C++
  • Python

Reproduction instructions

GitHub CI
@ramilbakhshyiev ramilbakhshyiev self-assigned this Aug 23, 2024
@ramilbakhshyiev
Copy link
Contributor Author

@ItsPitt @iotamudelta FAISS requested to created this issue to track the fixing of the C++ unit tests on MI250

@ramilbakhshyiev ramilbakhshyiev changed the title Fix code distance C++ unit tests for ROCm Fix code distance C++ unit tests for ROCm on MI250 Aug 23, 2024
facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@ramilbakhshyiev @facebook-github-bot
Do not unnecessarily install CUDA for ROCm
e442f01 
Summary: ROCm does not require CUDA, this change stops installing it. This is also likely to fix #3787 which is coming in a separate change.

Differential Revision: D62283602
@ramilbakhshyiev ramilbakhshyiev mentioned this issue Sep 6, 2024
Closed
facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@ramilbakhshyiev @facebook-github-bot
Do not unnecessarily install CUDA for ROCm (#3837)
66d9ae3 
Summary:

ROCm does not require CUDA, this change stops installing it. This is also likely to fix #3787 which is coming in a separate change.

Differential Revision: D62283602
facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@ramilbakhshyiev @facebook-github-bot
Do not unnecessarily install CUDA for ROCm (#3837)
d797946 
Summary:

ROCm does not require CUDA, this change stops installing it. This is also likely to fix #3787 which is coming in a separate change.

Differential Revision: D62283602
facebook-github-bot pushed a commit that referenced this issue Sep 6, 2024
@ramilbakhshyiev @facebook-github-bot
Do not unnecessarily install CUDA for ROCm (#3837)
cf55868 
Summary:

ROCm does not require CUDA, this change stops installing it. This is also likely to fix #3787 which is coming in a separate change.

Differential Revision: D62283602
@ramilbakhshyiev ramilbakhshyiev mentioned this issue Sep 6, 2024
Closed
@ramilbakhshyiev
Copy link
Contributor Author

Fixed by #3838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramilbakhshyiev ramilbakhshyiev

Labels
bug GPU module: rocm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramilbakhshyiev