Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with doctrine/dbal 2.6 #22

Merged
merged 2 commits into from
Sep 1, 2017
Merged

Conversation

Jean85
Copy link
Member

@Jean85 Jean85 commented Jul 27, 2017

As the upgrade guide of doctrine/dbal states, those are the only differences needed to up the compatibility of this package to 2.6.

@Jean85
Copy link
Member Author

Jean85 commented Jul 27, 2017

I've also added a changelog, to solve #20

Copy link
Member

@thomasvargiu thomasvargiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok IMHO 👍

Copy link
Member

@peelandsee peelandsee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peelandsee peelandsee merged commit f7c0998 into master Sep 1, 2017
@peelandsee peelandsee mentioned this pull request Sep 1, 2017
@Jean85 Jean85 deleted the dbal_2.6_compat branch September 1, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants