Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow renamed property for DBAL 2.9.0+ #32

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Allow renamed property for DBAL 2.9.0+ #32

merged 1 commit into from
Feb 5, 2019

Conversation

starred-gijs
Copy link
Contributor

Fixes #31

@Jean85
Copy link
Member

Jean85 commented Feb 4, 2019

Damn, build is failing due to HHVM... I think we should drop it.

@Jean85 Jean85 closed this Feb 4, 2019
@Jean85 Jean85 reopened this Feb 4, 2019
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Member

@peelandsee peelandsee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @starred-gijs

@Jean85 Jean85 added the bug label Feb 5, 2019
@Jean85 Jean85 merged commit fd1f600 into facile-it:master Feb 5, 2019
@starred-gijs starred-gijs deleted the dbal-renamed-property branch February 5, 2019 13:23
@starred-gijs
Copy link
Contributor Author

Awesome! Would you be so kind to release a new version?

@peelandsee
Copy link
Member

@starred-gijs
v1.7 tagged, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants