Add DBAL's MasterSlaveConnection support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninsuo
changed the title
ninsuo
force-pushed
the
master
branch
2 times, most recently
from
8867425 to
90035de
Compare
|
hey @ninsuo , just to confirm we're looking at this this week, sorry again.. |
|
merging, we'll tag a new release this week |
|
@ninsuo v1.8, released today, contains your merge thanks again, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
In Doctrine, the
Doctrine\DBAL\Connections\MasterSlaveConnectionclass is a wrapper that adds support to transparently use different read and write connections for a single database.This PR adds its support in a very simple way:
Connectionclass into a newConnectionTraitConnectionuse that traitConnectionclass intoMasterSlaveConnectionthat simply extends DBAL'sMasterSlaveConnectioninstead of DBAL'sConnectionConnectionInterfacein order to inject any of the 2 classes in the Facile'sStatementconstructor, instead ofConnectiononlyEverything works as expected on our project.
Please note: Doctrine places its
MasterSlaveConnectionin aConnectionsdirectory, so I respected their path even though it looks a bit strange.Thank you for your work and enjoy!
Alain