Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: factorialco/factorial-one
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.1
Choose a base ref
...
head repository: factorialco/factorial-one
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.6.0
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Mar 25, 2025

  1. feat(PageHeader): allow videos in product updates dropdown (#1463) 

    * feat(PageHeader): allow videos in product updates dropdown

* feat(PageHeader): renaming variable to convension

* feat(PageHeader): extract to isVideo function
    @ChloeDumit
    ChloeDumit authored Mar 25, 2025
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    3d99c43 View commit details

  2. chore(main): Core release 1.6.0 (#1466)

    @sergiocarracedo
    sergiocarracedo authored Mar 25, 2025
    Loading
    Loading status checks…

    Verified

    This commit was created on github.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    a02c169 View commit details
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"packages/react": "1.5.1"
"packages/react": "1.6.0"
}
7 changes: 7 additions & 0 deletions packages/react/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [1.6.0](https://github.com/factorialco/factorial-one/compare/v1.5.1...v1.6.0) (2025-03-25)


### Features

* **PageHeader:** allow videos in product updates dropdown ([#1463](https://github.com/factorialco/factorial-one/issues/1463)) ([3d99c43](https://github.com/factorialco/factorial-one/commit/3d99c439569410803ceed4352e46e885a0b031c1))

## [1.5.1](https://github.com/factorialco/factorial-one/compare/v1.5.0...v1.5.1) (2025-03-24)


2 changes: 1 addition & 1 deletion packages/react/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@factorialco/factorial-one",
"version": "1.5.1",
"version": "1.6.0",
"main": "dist/factorial-one.js",
"typings": "dist/factorial-one.d.ts",
"private": false,
9 changes: 5 additions & 4 deletions packages/react/src/experimental/Navigation/Header/PageHeader/index.stories.tsx
View file
Original file line number Diff line number Diff line change
@@ -223,27 +223,28 @@ export const WithProductUpdate: Story = {
{
title: "Project timetable with absence information",
href: "https://factorialmakers.atlassian.net/browse/FCT-24580",
imageURL: "https://placecats.com/neo/1416/797/",
mediaUrl:
"https://storage.googleapis.com/gtv-videos-bucket/sample/ForBiggerFun.mp4",
updated: "4 mar 2025",
unread: true,
},
{
title: "Project timetable with absence information",
href: "https://factorialmakers.atlassian.net/browse/FCT-24580",
imageURL: "https://placecats.com/neo/1416/797/",
mediaUrl: "https://placecats.com/neo/1416/797/",
updated: "4 mar 2025",
unread: true,
},
{
title: "New Client section",
imageURL: "https://placecats.com/neo/300/200",
mediaUrl: "https://placecats.com/neo/300/200",
updated: "3 mar 2025",
href: "https://factorialmakers.atlassian.net/browse/FCT-24580",
unread: true,
},
{
title: "Spending tab in projects",
imageURL: "https://placecats.com/neo/300/200",
mediaUrl: "https://placecats.com/neo/300/200",
updated: "2 mar 2025",
href: "https://factorialmakers.atlassian.net/browse/FCT-24580",
},
34 changes: 25 additions & 9 deletions packages/react/src/experimental/Navigation/Header/ProductUpdates/index.tsx
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ import {
type ProductUpdate = {
title: string
href: string
imageURL: string
mediaUrl: string
updated: string
unread?: boolean
onClick?: ComponentProps<typeof DropdownMenuItem>["onClick"]
@@ -163,12 +163,15 @@ const ProductUpdates = ({
const FeaturedDropdownItem = ({
title,
href,
imageURL,
mediaUrl,
unread,
updated,
onClick,
}: ProductUpdate) => {
const itemClass = "flex flex-col items-stretch gap-3 w-full"

const isVideo = mediaUrl?.includes(".mp4")

return (
<DropdownMenuItem asChild onClick={onClick}>
<Link
@@ -181,13 +184,26 @@ const FeaturedDropdownItem = ({
"text-f1-foreground no-underline hover:cursor-pointer"
)}
>
<div className="overflow-clip rounded border border-solid border-f1-border-secondary">
<Image
fetchPriority="high"
src={imageURL}
className="block aspect-video w-full bg-f1-background-secondary object-contain object-center"
/>
</div>
{isVideo ? (
<div className="overflow-clip rounded border border-solid border-f1-border-secondary">
<video
src={mediaUrl}
className="block aspect-video w-full bg-f1-background-secondary object-contain object-center"
autoPlay
muted
loop
playsInline
/>
</div>
) : (
<div className="overflow-clip rounded border border-solid border-f1-border-secondary">
<Image
fetchPriority="high"
src={mediaUrl}
className="block aspect-video w-full bg-f1-background-secondary object-contain object-center"
/>
</div>
)}
<div className="flex items-start gap-4">
<div className="flex-1 *:text-base">
<h3 className="font-medium">{title}</h3>