feat(PageHeader): allow videos in product updates dropdown #1463
+30
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
nlopin
reviewed
Mar 25, 2025
packages/react/src/experimental/Navigation/Header/ProductUpdates/index.tsx
Outdated
Show resolved
Hide resolved
nlopin
reviewed
Mar 25, 2025
| className="block aspect-video w-full bg-f1-background-secondary object-contain object-center" | ||
| /> | ||
| </div> | ||
| {mediaURL?.includes(".mp4") ? ( |
There was a problem hiding this comment.
let's extract this to a function isVideo for future modifications
nlopin
approved these changes
Mar 25, 2025
This was referenced Mar 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow videos in product updates dropdown
Screenshots (if applicable)
Figma Link
Link to Figma Design
Type of Change