Extend CalendarEvent component #973
Merged
+368
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
nlopin
reviewed
Dec 17, 2024
nlopin
reviewed
Dec 17, 2024
nlopin
reviewed
Dec 17, 2024
nlopin
reviewed
Dec 17, 2024
nlopin
reviewed
Dec 17, 2024
nlopin
reviewed
Dec 17, 2024
| } | ||
| fromDate?: Date | ||
| toDate: Date | ||
| showBackground?: boolean |
There was a problem hiding this comment.
maybe noBackground and have it false by default?
It is nicer when using the component. Instead of:
<CalendarEvent showBackground={false} />
I can do
<CalendarEvent noBackground />
nlopin
reviewed
Dec 17, 2024
| <div className="flex flex-row items-center justify-between"> | ||
| <div className="flex flex-1 flex-row items-center gap-1.5"> | ||
| {tags.map((tag) => ( | ||
| <Tooltip |
There was a problem hiding this comment.
I've started to think recently whether asChildren in the tooltip was a good idea. We have to wrap things with divs to make the tooltip works, killing the accessibility.
No need to fix it here, let's discuss it on the upcoming sync
There was a problem hiding this comment.
Perfect! Yep, maybe we could come up with another solution
nlopin
reviewed
Dec 17, 2024
| description={tag.description} | ||
| > | ||
| <div> | ||
| <RawTag icon={tag.icon} /> |
There was a problem hiding this comment.
pass additionalAccesibleText to the tag with the description and the label. The tooltip isn't be reachable by screen readers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend CalendarEvent component.
Screenshots