Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WP]test: #5555 migrate from tap to node:test #364

Closed
wants to merge 1 commit into from

Conversation

JohnMikko27
Copy link

Checklist

@JohnMikko27
Copy link
Author

JohnMikko27 commented Jan 29, 2025

Hi, I'm new to contributing to Fastify and saw the discussion fastify #5555 about migrating from tap to node:test. I made a PR but it's still a work in progress as I just wanted to make sure that what I've done so far is fine. Please let me know, thank you for your time.

@Eomm
Copy link
Member

Eomm commented Mar 5, 2025

Thanks for opening this PR - the first step was good indeed but the changes were a lot.

I would suggest to start with a smaller issue like this one: #316 where we can support you in a smaller use case

Superseded by #367

@Eomm Eomm closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants