-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Optimize SQL Registry proto() method #4425
fix: Optimize SQL Registry proto() method #4425
Conversation
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
0d5b008
to
3a0dee8
Compare
This is great! Would you mind adding maybe a test or two? Since we're changing the function names and quite a bit of the code it'd be helpful. Separately, it would be super cool to do a blood post to hear about your experience scaling Feast, if you'd be open to it! |
Signed-off-by: Bhargav Dodla <bdodla@expediagroup.com>
@franciscojavierarceo Sorry. I would have marked this as a Draft PR. Added tests, integration tests for the changes. I assume you are asking for blog post. It's in our plan to publish a blog. We will share the details when we have a Draft ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! /lgtm
@EXPEbdodla I think this definitely needs to be broken up into several PRs.
|
An endpoint like |
@tokoko I haven't used the other registry's so I'm cautious in touching them at the moment. Do we need to do that before merging this PR? |
@tokoko @franciscojavierarceo Created PR #4441 to add methods to base registry. I'll update this PR to cover the tests cases fully along with the changes for this. |
Closing this. This is split into multiple PRs already. Thanks everyone for inputs. |
What this PR does / why we need it:
Problem Summary: We are using SQL Registry with 150+ projects and ~600 feature views at the moment. They are going to grow in future.
1 . Starting up a Remote registry service is taking longer than expected due to proto() call during Registry initialization. This has to refresh all 150 projects metadata on start up.
2 . Refreshing the cache on a regular interval with cache_mode = thread taking longer even though most of the projects object (like entities, FVs, ODFVs) doesn't change so often.
Fixes:
thread_pool_executor_worker_count
configuration. If its 0, doesn't use ThreadPoolExecutor.Questions:
Which issue(s) this PR fixes:
Misc