Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added rbac examples #4450

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

redhatHameed
Copy link
Contributor

@redhatHameed redhatHameed commented Aug 26, 2024

What this PR does / why we need it:

Added RBAC example with remote server components deployment on Kubernetes with authorization type Kubernetes and OIDC(using keycloak).

Which issue(s) this PR fixes:

Misc

@redhatHameed redhatHameed changed the title example: [WIP] added rbac examples chore: [WIP] added rbac examples Aug 26, 2024
@redhatHameed redhatHameed changed the title chore: [WIP] added rbac examples chore: WIP Added rbac examples Aug 26, 2024
@redhatHameed redhatHameed force-pushed the rbac-examples branch 2 times, most recently from a0e5433 to 680a139 Compare August 30, 2024 14:45
Signed-off-by: Abdul Hameed <ahameed@redhat.com>
@redhatHameed redhatHameed changed the title chore: WIP Added rbac examples chore: Added rbac examples Sep 5, 2024
@redhatHameed redhatHameed marked this pull request as ready for review September 5, 2024 01:58
@redhatHameed
Copy link
Contributor Author

@dmartinol @tokoko @franciscojavierarceo @dandawg This PR ready for review once get chance thanks

Signed-off-by: Abdul Hameed <ahameed@redhat.com>
@franciscojavierarceo
Copy link
Member

@redhatHameed can we split out the two examples into two PRs? 😅

@redhatHameed
Copy link
Contributor Author

redhatHameed commented Sep 5, 2024

@redhatHameed can we split out the two examples into two PRs? 😅

sure removed the rbac-local example with notebook which will be added into next PR

Copy link
Contributor

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OIDC setup should be reviewed

Signed-off-by: Abdul Hameed <ahameed@redhat.com>
@redhatHameed
Copy link
Contributor Author

OIDC setup should be reviewed

updated let me know WDYT ?

Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits to the readme. This is great! Thanks Hameed!

Co-authored-by: Francisco Arceo <farceo@redhat.com>
@redhatHameed
Copy link
Contributor Author

Some small nits to the readme. This is great! Thanks Hameed!

@franciscojavierarceo Thanks for reviewing, updated accordingly

@franciscojavierarceo franciscojavierarceo merged commit 0c90137 into feast-dev:master Sep 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants