add iterators exercise #161
Conversation
miguelraz
changed the title
Deploying ferrous-systems-rust-exercises with
|
| Latest commit: |
a014833
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://798191d7.ferrous-systems-rust-exercises.pages.dev |
| Branch Preview URL: | https://iterators-exercise.ferrous-systems-rust-exercises.pages.dev |
|
I still don't know why the code exits with a 1. |
exercise-book/src/iterators.md
Outdated
|
|
||
| - Take the template in [exercise-templates/iterators](../../exercise-templates/iterators/) as a starting point. | ||
| - Replace the first `todo!` item with [reader.lines()]() and continue "chaining" the iterators until you've calculated the desired result. | ||
| - Run the code with `cargo run --bin iterators1` when inside the `exercise-templates` directory |
There was a problem hiding this comment.
While for embedded training we expect the group to clone exercises repo and work within it, for our intro exercises we actually prompt them to make a separate new rust project for each of them.
There was a problem hiding this comment.
Got it. Rephrased this section. Will wait on another review until I resolve.
exercise-book/src/iterators.md
Outdated
|
|
||
| let result = reader.lines() | ||
| .map(|l| l.unwrap()) | ||
| .filter_map(|s| s.parse().ok()) |
There was a problem hiding this comment.
While I appreciate a gradual progression on the solution, this particular sequence of steps (Step 2 to Step 6) goes against of what we teach people on trainings. They don't "unwarp() now, refactor later". Instead as soon as trainee sees a Result, they will think how to properly handle it. The final solution won't have any unwrap / expect calls in code. So I would give a different hint early: about the fact that in this problem we skip over "bad" lines, and then use this fact to introduce filter_map as an important method.
Co-authored-by: Andrei Listochkin (Андрей Листочкин) <andrei.listochkin@ferrous-systems.com>
Co-authored-by: Andrei Listochkin (Андрей Листочкин) <andrei.listochkin@ferrous-systems.com>
Co-authored-by: Andrei Listochkin (Андрей Листочкин) <andrei.listochkin@ferrous-systems.com>
Co-authored-by: Andrei Listochkin (Андрей Листочкин) <andrei.listochkin@ferrous-systems.com>
|
Don't forget to add it to ToC! |
|
please don't merge things unless CI is green |
No description provided.