Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File io #50

Merged
merged 4 commits into from
May 3, 2022
Merged

File io #50

merged 4 commits into from
May 3, 2022

Conversation

Pan-Maciek
Copy link
Contributor

@Pan-Maciek Pan-Maciek commented Apr 28, 2022

Added a convenience function used by FileIO. This makes it easy to work with multiple filetypes at the same time.

Before:

using FileIO
using NPZ

model = load("model-001.ply")
keypoints = npzread("keypoints.npz", ["001"])
camera = npzread("camera.npy")

after

using FileIO

model = load("model-001.ply")
keypoints = load("keypoints.npz", ["001"])
camera = load("camera.npy")

If it can be merged I have changes ready to integrate it with FileIO on their side.
FileIO fork
MR

mkozieja and others added 2 commits April 28, 2022 20:15
Later NPY can use file magic to be detected, while NPZ is just a zip and must be detected via file extension.
johnnychen94
johnnychen94 previously approved these changes Apr 30, 2022
@fhs fhs merged commit 3f0b7dd into fhs:master May 3, 2022
@johnnychen94
Copy link

@fhs maybe bump a new version for this? That way I can also merge JuliaIO/FileIO.jl#358 and make a new FileIO release.

@Pan-Maciek Pan-Maciek deleted the FileIO branch May 3, 2022 19:03
@fhs
Copy link
Owner

fhs commented May 3, 2022

@johnnychen94 Created JuliaRegistries/General#59603

@CarloLucibello
Copy link
Collaborator

@Pan-Maciek could you also add some tests for this?

@johnnychen94
Copy link

That way I can also merge JuliaIO/FileIO.jl#358 and make a new FileIO release.

FileIO v1.14.0: JuliaRegistries/General#59636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants