Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PRE_COMMIT_SECTOR_BATCH_MAX_SIZE and other gas-limited parameters #1268

Closed
Tracked by #1274
jennijuju opened this issue Apr 3, 2023 · 1 comment · Fixed by #1586
Closed
Tracked by #1274

Remove PRE_COMMIT_SECTOR_BATCH_MAX_SIZE and other gas-limited parameters #1268

jennijuju opened this issue Apr 3, 2023 · 1 comment · Fixed by #1586
Assignees
@rvagg
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Profiling, harden...

Comments

@jennijuju
Copy link
Member

related to filecoin-project/lotus#10612

tl'dr: with FVM the execution gas are now properly accounted, and if the FVM gas accounting changes, the max value of how many msg can fit in one block may change.

Its better to remove thee limit from actors and have clients to perform gas estimation and properly aggregate sectors for users accordingly
@jennijuju jennijuju added the enhancement New feature or request label Apr 3, 2023
@jennijuju jennijuju added this to the 2023 Actor 🧹 milestone Apr 3, 2023
@anorth
Copy link
Member

anorth commented Apr 3, 2023 •
edited
Loading

There are other parameters that can be removed too, e.g. around Window PoSt.

  • DECLARATIONS_MAX

@ZenGround0 ZenGround0 added the good first issue Good for newcomers label May 9, 2023
@jennijuju jennijuju mentioned this issue May 19, 2023
Closed
@anorth anorth changed the title Remove MAX_AGGREGATED_SECTORS and PRE_COMMIT_SECTOR_BATCH_MAX_SIZE Remove PRE_COMMIT_SECTOR_BATCH_MAX_SIZE and other gas-limited parameters May 27, 2024
This was referenced May 27, 2024
Closed
Closed
@rjan90 rjan90 added this to FilOz Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 17, 2024
@rjan90 rjan90 moved this from 📌 Triage to 🐱 Todo in FilOz Sep 17, 2024
@leinss leinss mentioned this issue Oct 11, 2024
Closed
@kamuik16 kamuik16 mentioned this issue Oct 22, 2024
Merged
@rjan90 rjan90 moved this from 🐱 Todo to ⌨️ In Progress in FilOz Oct 22, 2024
@rjan90 rjan90 moved this from ⌨️ In Progress to 🔎 Awaiting review in FilOz Dec 20, 2024
@rjan90 rjan90 moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FilOz Jan 6, 2025
rvagg added a commit to filecoin-project/FIPs that referenced this issue Jan 7, 2025
@rvagg
Add removal of gas-limited constraints to gas-savings proposal
4070add 
Ref: #1094
Ref: filecoin-project/builtin-actors#1586
Ref: filecoin-project/builtin-actors#1268
Ref: filecoin-project/lotus#10612
@rvagg rvagg mentioned this issue Jan 7, 2025
Merged
irenegia pushed a commit to filecoin-project/FIPs that referenced this issue Jan 15, 2025
@rvagg
Add removal of gas-limited constraints to gas-savings proposal (#1098)
f2e3e3c 
* Add removal of gas-limited constraints to gas-savings proposal

Ref: #1094
Ref: filecoin-project/builtin-actors#1586
Ref: filecoin-project/builtin-actors#1268
Ref: filecoin-project/lotus#10612

* fixup! Add removal of gas-limited constraints to gas-savings proposal
@BigLep BigLep moved this from 🐱 Todo to 🔎 Awaiting Review in nv25 Track Board Feb 14, 2025
@rvagg rvagg moved this from 🔎 Awaiting Review to ✔️ Approved by reviewer in nv25 Track Board Feb 24, 2025
@rvagg rvagg closed this as completed Mar 12, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Mar 12, 2025
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in nv25 Track Board Mar 12, 2025
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvagg rvagg

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
FilOz
Status: ☑️ Done (Archive)
nv25 Track Board
Status: 🎉 Done
Milestone
Profiling, hardening and cleanups'23
4 participants
@anorth @rvagg @ZenGround0 @jennijuju