refactor: support go 1.24 with newtypes #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/go-1.24-with-newtypes
branch
2 times, most recently
from
41a93b2 to
617ea5b
Compare
Stebalien
force-pushed
the
steb/go-1.24-with-newtypes
branch
2 times, most recently
from
da2658f to
5727a01
Compare
Stebalien
force-pushed
the
steb/go-1.24-with-newtypes
branch
from
5727a01 to
682c4c7
Compare
masih
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #517 that uses newtypes. IMO, this is a bit less risky as we're not introducing any new pointers, wrappers, etc.