Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teep pricing changes #2103

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Teep pricing changes #2103

merged 1 commit into from
Mar 14, 2025

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien Stebalien marked this pull request as draft February 12, 2025 23:17
@Stebalien Stebalien changed the title [DO NOT MERGE] Sketch out how we can add new price lists. [WIP] Teep pricing changes Feb 12, 2025
@Stebalien Stebalien changed the title [WIP] Teep pricing changes Teep pricing changes Feb 12, 2025
@Stebalien Stebalien marked this pull request as ready for review February 12, 2025 23:20
@Stebalien Stebalien requested a review from rvagg February 12, 2025 23:22
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.95%. Comparing base (525faea) to head (61337f1).

Files with missing lines Patch % Lines
fvm/src/gas/price_list.rs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
- Coverage   75.96%   75.95%   -0.01%     
==========================================
  Files         154      154              
  Lines       15771    15772       +1     
==========================================
  Hits        11980    11980              
- Misses       3791     3792       +1     
Files with missing lines Coverage Δ
fvm/src/gas/price_list.rs 77.47% <50.00%> (-0.16%) ⬇️

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably hold off on merging this for now eh?

@Stebalien
Copy link
Member Author

we should probably hold off on merging this for now eh?

Yeah, probably.

@Stebalien
Copy link
Member Author

I also made a bunch of other changes in https://github.com/filecoin-project/ref-fvm/pull/1854/files and I want to make sure we're not missing something.

@Stebalien
Copy link
Member Author

Ok, I made two changes there:

  1. I charged less for batches, assuming some amount of parallelism.
  2. I changed some functions around, but that had no real impact on functionality.

@rvagg rvagg linked an issue Feb 14, 2025 that may be closed by this pull request
3 tasks
@BigLep
Copy link
Member

BigLep commented Feb 25, 2025

we should probably hold off on merging this for now eh?

Yeah, probably.

When do we plan to merge this?

@rvagg
Copy link
Member

rvagg commented Feb 25, 2025

If FIP-0100 gets accepted this gets merged. If it doesn't get accepted we're going to need to have another talk about this.

@BigLep
Copy link
Member

BigLep commented Mar 13, 2025

@rvagg : I assume we're good to merge this now that FIP-0100 is effectively accepted (and will be accepted by EI=OD 2025-03-14).

I assume there is communication we need to do with consumers like Venus and Forest to make sure they update?

@rvagg
Copy link
Member

rvagg commented Mar 13, 2025

We have #2107 too, but when we cut a release they'll need to update.

@rjan90 rjan90 merged commit aaf5155 into master Mar 14, 2025
14 checks passed
@rjan90 rjan90 deleted the steb/price-list-def branch March 14, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

Fix gas accounting for seal proof verification
5 participants