Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to cargo-deny and fix some lints #2111

Merged
merged 1 commit into from
Mar 14, 2025
Merged

chore: switch to cargo-deny and fix some lints #2111

merged 1 commit into from
Mar 14, 2025

Conversation

Stebalien
Copy link
Member

  • Update url dependency. We don't use it directly, but wasmtime does.
  • Update the builtin actors (dev) dependency to remove some crufty dependencies.
  • Add licenses everywhere.

@Stebalien
chore: switch to cargo-deny and fix some lints
ba8017c 
- Update url dependency. We don't use it directly, but wasmtime does.
- Update the builtin actors (dev) dependency to remove some crufty dependencies.
- Add licenses everywhere.
@Stebalien Stebalien requested a review from rjan90 March 14, 2025 19:11
@Stebalien
Copy link
Member Author

This fixes the CI issue by simply swapping cargo-audit with the newer/better cargo-deny (which we also use in the builtin actors).

Stebalien
Stebalien commented Mar 14, 2025
View reviewed changes
deny.toml
]

[bans]
multiple-versions = "allow"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2112

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.95%. Comparing base (aaf5155) to head (ba8017c).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2111   +/-   ##
=======================================
  Coverage   75.95%   75.95%           
=======================================
  Files         154      154           
  Lines       15772    15772           
=======================================
  Hits        11980    11980           
  Misses       3792     3792
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Stebalien
Stebalien commented Mar 14, 2025
View reviewed changes
deny.toml
Comment on lines +14 to +24
"Apache-2.0",
"Apache-2.0 WITH LLVM-exception",
"BSD-2-Clause",
"BSD-3-Clause",
"CC0-1.0",
"MIT",
"NCSA",
"Unlicense",
"MPL-2.0",
"Unicode-3.0",
"Zlib",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all "permissive" licenses. But we should try to trim down our dependency tree a bit.

@Stebalien Stebalien merged commit e7f0bc6 into master Mar 14, 2025
15 checks passed
@Stebalien Stebalien deleted the steb/cargo-deny branch March 14, 2025 19:23
@rjan90 rjan90 mentioned this pull request Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjan90 rjan90 rjan90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
FilOz
Status: ☑️ Done (Archive)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @codecov-commenter @rjan90