expose staged sector metadata through FFI #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laser
force-pushed
the
feat/expose-staged-sector-metadata
branch
from
c041e66 to
124f7c4
Compare
| @@ -6,13 +6,12 @@ use serde::{Deserialize, Serialize}; | |||
| use serde_big_array::BigArray; | |||
| use std::fmt; | |||
|
|
|||
| #[derive(Default, Clone, Serialize, Deserialize, Debug, PartialEq)] | |||
There was a problem hiding this comment.
why no default anymore?
There was a problem hiding this comment.
and I found it down below, but you could have it easier by deriving default here and implementing it on SealStatus
There was a problem hiding this comment.
Oh, that's a much better idea. Thanks. Good call.
dignifiedquire
approved these changes
Dec 7, 2018
|
@laser anything stopping this PR from being merged? |
laser
force-pushed
the
feat/expose-staged-sector-metadata
branch
from
124f7c4 to
fc6ef35
Compare
- replace StagedSectorMetadata.sealing_error and accepting_data with seal_status - add new get_staged_sectors method + FFI function
sidke
force-pushed
the
feat/expose-staged-sector-metadata
branch
from
fc6ef35 to
2e7bd24
Compare
sidke
force-pushed
the
feat/expose-staged-sector-metadata
branch
from
d66dcc6 to
7925b35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the rust-proofs side of this go-filecoin issue.
What's in this PR?