Changed fs.watch.spec.js according to filed issue-666 #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 16 16
Lines 1746 1746
=======================================
Hits 1514 1514
Misses 232 232Continue to review full report at Codecov.
|
humphd
reviewed
Jan 31, 2019
| @@ -126,4 +128,4 @@ describe('fs.watch', function() { | |||
| }); | |||
| }); | |||
| }); | |||
| }); | |||
| }); | |||
There was a problem hiding this comment.
One tip: it's always a good idea to end files with a newline. We do this for cases where files get processed/concatenated together, and you want to avoid the case that the last line of one file, and the first line of the next, get joined and cause an error.
humphd
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file had its variable being declared with usage of "var" -> changed to "let" and "const" where applicable; added "use strict" at global scope.