Fix event listener method signature bug #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since BDK 2.13.0, the RealTimeEvent object is actually a sub type of the original V4 event type, therefore change the Spring event listener method signature to include the sub type of the event. It is also a good practice to include the sub type to have maximum extensibility in the code.
yinan-symphony
force-pushed
the
bugfix/event-listener
branch
from
2bf78fc to
abd169c
Compare
symphony-soufiane
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since BDK 2.13.0, the RealTimeEvent object is actually a sub type of the original V4 event type, therefore change the Spring event listener method signature to include the sub type of the event.
It is also a good practice to include the sub type to have maximum extensibility in the code.
Description
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist