Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up net_hdrs #4478

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Clean up net_hdrs #4478

merged 1 commit into from
Mar 12, 2025

Conversation

ripatel-fd
Copy link
Contributor

  • Fix alignment of ip4_hdr and udp_hdr
  • Rename net_hdrs to ip4_udp_hdrs
  • Use strongly typed syntax for ip4_udp_hdrs to avoid pointer bugs

@ripatel-fd ripatel-fd force-pushed the ripatel/net-headers branch 3 times, most recently from 76be190 to 777275c Compare March 11, 2025 17:54
jumpsiegel
jumpsiegel previously approved these changes Mar 11, 2025
View reviewed changes
@ripatel-fd ripatel-fd force-pushed the ripatel/net-headers branch from 777275c to 57bda86 Compare March 12, 2025 15:30
@riptl
Clean up net_hdrs
a51a8f2 
- Fix alignment of ip4_hdr and udp_hdr
- Rename net_hdrs to ip4_udp_hdrs
- Use strongly typed syntax for ip4_udp_hdrs to avoid pointer bugs
- Disable UDP checksums
@ripatel-fd ripatel-fd force-pushed the ripatel/net-headers branch from 57bda86 to a51a8f2 Compare March 12, 2025 15:47
lidatong
lidatong approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@lidatong lidatong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i realize it's an artifact of what was already there but we should at some point refactor out the hdr filling in a waltz or disco util

@ripatel-fd ripatel-fd added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit bd0cbcb Mar 12, 2025
11 checks passed
@ripatel-fd ripatel-fd deleted the ripatel/net-headers branch March 12, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidatong lidatong lidatong approved these changes

@jumpsiegel jumpsiegel jumpsiegel left review comments

@ptaffet-jump ptaffet-jump Awaiting requested review from ptaffet-jump ptaffet-jump is a code owner

@mmcgee-jump mmcgee-jump Awaiting requested review from mmcgee-jump mmcgee-jump is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ripatel-fd @lidatong @jumpsiegel @riptl