Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stackIndex existence check at if condition in SampleTooltipContents #5353

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Move stackIndex existence check at if condition in SampleTooltipContents #5353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/shared/SampleTooltipContents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ export class SampleTooltipContents extends React.PureComponent<Props> {
const sampleTime = samples.time[sampleIndex];
const stackIndex = samples.stack[sampleIndex];
const hasSamples = samples.length > 0 && stackTable.length > 1;
const hasValidStackIndex = (stackIndex !== null) || (stackIndex !== undefined);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| needs to be && here. We need to make sure that stack index is not null AND not undefined. (also there is an extra space on the right side of the or operator).


if (hasSamples) {
if (hasSamples && hasValidStackIndex) {
const stack = getFuncNamesAndOriginsForPath(
convertStackToCallNodeAndCategoryPath(
rangeFilteredThread,
Expand Down