Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE for 'cannot read dryrun of undefined' #88

Merged
merged 7 commits into from
Aug 3, 2021
Merged

Fix NPE for 'cannot read dryrun of undefined' #88

merged 7 commits into from
Aug 3, 2021

Conversation

tuffant21
Copy link
Contributor

@tuffant21 tuffant21 commented Jul 30, 2021 •
edited
Loading

Fixed issue: #87

fiznool
fiznool requested changes Jul 30, 2021
View reviewed changes
Copy link
Owner

@fiznool fiznool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please could you make a couple of changes:

  • Can you add a test which reproduces this error? We will then have a guard against this from happening again in the future.
  • Please revert the changes to the version string, this will be handled with a separate commit.

@tuffant21 tuffant21 requested a review from fiznool July 30, 2021 15:45
@tuffant21
Copy link
Contributor Author

@fiznool updated!

@tuffant21
Copy link
Contributor Author

@fiznool Could you run the checks on this again?

fiznool
fiznool requested changes Aug 3, 2021
View reviewed changes
Copy link
Owner

@fiznool fiznool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - just a few other things to look at. Also, please could you revert the changes to the lockfile, these changes shouldn't merit any edits there.

@tuffant21 tuffant21 requested a review from fiznool August 3, 2021 19:04
@tuffant21
Copy link
Contributor Author

@fiznool done 👍

fiznool
fiznool approved these changes Aug 3, 2021
View reviewed changes
Copy link
Owner

@fiznool fiznool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for this!

I am away from my computer atm but will cut a new release when I'm back.

@fiznool fiznool merged commit acac3ef into fiznool:master Aug 3, 2021
@tuffant21
Copy link
Contributor Author

@fiznool Sounds great, thank you!

@fiznool fiznool mentioned this pull request Jan 14, 2022
Closed
@MRdevX MRdevX mentioned this pull request Sep 7, 2024
Open
@Emmanuel97423 Emmanuel97423 mentioned this pull request Sep 7, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request Sep 9, 2024
Open
@LucileGombert LucileGombert mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiznool fiznool fiznool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuffant21 @fiznool