Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtin harfbuzz to workaround GDExtension crash #211

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

j20001970
Copy link
Contributor

Since godotengine/godot#100052 is merged in v4.4, we can now configure linux dependency modules independently.

Currently Godot has a bug (godotengine/godot#91401) that if the engine is using system-provided harfbuzz library, it will crash when GDExtension libraries call std::call_once during static initialization. Libraries with such pattern are including but not limited to Tensorflow/Protobuf-based projects, GDExtension libraries with these dependencies will always crash flatpak Godot unless builtin harfbuzz is used.

This PR remove the builtin_harfbuzz=no from Scons flags, making the editor to use builtin harfbuzz instead of system-provided one from Freedesktop SDK/Platform. The editor executable size increase in my testing is from 139.2 MiB (145,966,624) to 139.9 MiB (146,660,800) which is acceptable at the scale of flatpak apps IMO.

@flathubbot
Copy link
Contributor

Started test build 184476

@flathubbot
Copy link
Contributor

Build 184476 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/167702/org.godotengine.Godot.flatpakref

@Calinou Calinou added the bug Something isn't working label Mar 4, 2025
Copy link
Collaborator

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 621424f into flathub:master Mar 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants