Allow import of encrypted PDF files #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function pdf_encryption_check_and_dialog checks if the file can be opened without a password and if that fails proceeds to prompt the user for the password. The user is repeatedly prompted for a new password until opening the file succeeds or the user cancels the import.
In order to allow for the translation of the new pdf password dialog labels
flxzt
reviewed
Nov 9, 2024
Animate the ListBox containing the password entry instead of the entry itself
|
looks very good, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements my suggestion from the Issue #1260 allowing for the import of encrypted PDF files by prompting the user for a password and passing it along to all appropriate poppler::Document calls.
I also provide the German translation of the new dialog used to prompt for the PDF password.